Suppress /Workspace prefix diff for experiment names in direct deployment#4627
Merged
shreyas-goenka merged 2 commits intomainfrom Mar 13, 2026
Merged
Suppress /Workspace prefix diff for experiment names in direct deployment#4627shreyas-goenka merged 2 commits intomainfrom
shreyas-goenka merged 2 commits intomainfrom
Conversation
shreyas-goenka
requested review from
andrewnester,
anton-107,
denik and
pietern
as code owners
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: ccb2482
31 interesting tests: 12 flaky, 7 SKIP, 7 RECOVERED, 5 FAIL
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
reviewed
Mar 3, 2026
Contributor
andrewnester
left a comment
andrewnester
left a comment
There was a problem hiding this comment.
I'm not entirely sure that TF behaviour is correct; we should have all workspace paths prefixed with /Workspace. Can this be fixed in the TF provider instead?
Contributor
Author
|
The backend always strips the |
Contributor
|
Another option, less drastic and future proof (in case backend stops stripping) is to implement OverrideChangeDesc that compares strings with stripped prefix. |
denik
approved these changes
Mar 13, 2026
The direct deployment engine was sending experiment names with the /Workspace prefix to the API, while the Terraform provider strips it. This caused divergent behavior between the two engines. Fixes #4285 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
shreyas-goenka
force-pushed
the
fix-workspace-prefix
branch
from
d3d4f80 to
9d4c607
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
shreyas-goenka
force-pushed
the
fix-workspace-prefix
branch
from
406e431 to
2e6fb16
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
reviewed
Mar 13, 2026
|
|
||
| trace $CLI experiments get-experiment ${EXPERIMENT_ID} | jq '{name: .experiment.name, lifecycle_stage: .experiment.lifecycle_stage}' > out.get.$DATABRICKS_BUNDLE_ENGINE.json | ||
| # Plan should show no changes with /Workspace/Users/... path in config | ||
| trace $CLI bundle plan |
Contributor
There was a problem hiding this comment.
can we record change from json change?
Use OverrideChangeDesc to normalize the /Workspace prefix on experiment names instead of stripping it in apply_presets, matching the Terraform provider's experimentNameSuppressDiff behavior. Add acceptance test coverage for both /Workspace/Users/... and /Users/... path forms. Co-authored-by: Isaac
shreyas-goenka
force-pushed
the
fix-workspace-prefix
branch
from
2e6fb16 to
ccb2482
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 96d017a
43 interesting tests: 23 RECOVERED, 13 FAIL, 5 flaky, 1 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OverrideChangeDescto suppress the/Workspaceprefix diff on experiment names, matching the Terraform provider'sexperimentNameSuppressDiffbehaviorExperimentUpdateto strip/Workspaceprefix, matching cloud behavior/Workspace/Users/...and/Users/...path forms:q :Q erge remote-tracking branch 'origin' into fix-fuse-generate #4324
Why?
The backend always strips the
/Workspaceprefix from experiment names, so remote returns/Users/...while the config has/Workspace/Users/.... Instead of mutating the config value (stripping the prefix inApplyPresets), we suppress the diff during change detection viaOverrideChangeDesc— the same approach the Terraform provider uses with itsexperimentNameSuppressDifffunction.Without this fix you get a persistent drift:
Test plan
bundle/deployment/bind/experimentverifies plan shows 0 changes with/Workspace/Users/...path/Users/...path (without/Workspaceprefix)bundle/resources/experiments/basicacceptance test still passes🤖 Generated with Claude Code